Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

fix(config): change application name and website [MOSOWEB-90] #88

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

jpezninjo
Copy link

@jpezninjo jpezninjo commented Nov 20, 2023

MOSOWEB-90

Goal

Bug: When you post on mozilla.social, your post gets a label that says “Elk” and links to “elk.zone”.

Context

Posts have an application field with name and website data. application refers to an instance of Application

status.application.name: "Elk"
status.application.website: "https://elk.zone/"

Fix

Change the application name and website fields. This PR is a frontend fix to a fetch call. Backend will do a fix to actually update name and website

@jpezninjo jpezninjo requested a review from a team as a code owner November 20, 2023 21:35
@@ -1,4 +1,5 @@
export const APP_NAME = 'Elk'
export const APP_NAME = 'Mozilla.social'
export const APP_WEBSITE = 'https://mozilla.social'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've felt bad defining a constant for something that gets used once if APP_NAME wasn't also only used once.

Copy link

@wtfluckey wtfluckey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done tracking this one down!

@jpezninjo jpezninjo merged commit e39dc8b into main Nov 27, 2023
5 checks passed
@jpezninjo jpezninjo deleted the fix/moso-application-fields branch November 27, 2023 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants